Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sys.excepthook error when running tests #595

Merged
merged 5 commits into from Apr 10, 2020
Merged

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Apr 8, 2020

Fixes #562.

Will file another issue for a decorator/subclass solution.
Should also fix estimators showing up as classes and not strings in docs for component_graphs

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #595 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         118      118           
  Lines        4453     4456    +3     
=======================================
+ Hits         4403     4406    +3     
  Misses         50       50           
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 98.55% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc2f3b...7886fec. Read the comment docs.

@jeremyliweishih jeremyliweishih self-assigned this Apr 8, 2020
@jeremyliweishih
Copy link
Contributor Author

jeremyliweishih commented Apr 8, 2020

Looks good. Error doesn't show up in build logs!

@jeremyliweishih jeremyliweishih changed the title [WIP] Fix sys.excepthook error when running tests Fix sys.excepthook error when running tests Apr 8, 2020
@dsherry
Copy link
Collaborator

dsherry commented Apr 8, 2020

Will file another issue for a decorator/subclass solution.

What do you mean by that?

dsherry
dsherry approved these changes Apr 8, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

👍 🚢 awesome!

@jeremyliweishih
Copy link
Contributor Author

jeremyliweishih commented Apr 8, 2020

What do you mean by that?

@dsherry I was thinking about filing a ticket detailing a solution using __init_subclass and class decorators to make class variables immutable. Do you think its necessary?

@dsherry
Copy link
Collaborator

dsherry commented Apr 8, 2020

@jeremyliweishih ooh neat, I'm interested!

@jeremyliweishih
Copy link
Contributor Author

jeremyliweishih commented Apr 10, 2020

@dsherry I added to #561 with more info about using class decorators etc for this as well.

@jeremyliweishih jeremyliweishih merged commit fa399cc into master Apr 10, 2020
2 checks passed
@dsherry dsherry deleted the js_562_sys branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in sys.excepthook during automl unit tests
2 participants