Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop htmlzip download format from readthedocs, leaving only pdf #600

Merged
merged 2 commits into from Apr 8, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Apr 8, 2020

We're still seeing RTD timeouts on @angela97lin 's feature branch for #346 , so dropping down to PDF as our only download artifact.

@dsherry dsherry added documentation Improvements or additions to documentation testing Issues related to testing. labels Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #600 into master will increase coverage by 14.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #600       +/-   ##
===========================================
+ Coverage   84.39%   98.87%   +14.48%     
===========================================
  Files         118      118               
  Lines        4453     4453               
===========================================
+ Hits         3758     4403      +645     
+ Misses        695       50      -645     
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 98.53% <0.00%> (+0.48%) ⬆️
evalml/tests/component_tests/test_components.py 100.00% <0.00%> (+0.62%) ⬆️
evalml/automl/auto_base.py 96.19% <0.00%> (+0.69%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.63% <0.00%> (+2.94%) ⬆️
evalml/tests/component_tests/test_utils.py 96.42% <0.00%> (+3.57%) ⬆️
evalml/tests/utils_tests/test_dependencies.py 100.00% <0.00%> (+6.25%) ⬆️
evalml/pipelines/classification/xgboost.py 100.00% <0.00%> (+12.50%) ⬆️
...nents/estimators/classifiers/xgboost_classifier.py 100.00% <0.00%> (+13.63%) ⬆️
evalml/pipelines/regression/catboost.py 100.00% <0.00%> (+14.28%) ⬆️
evalml/pipelines/classification/catboost.py 100.00% <0.00%> (+14.28%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b97358...f1f19e6. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

LGTM. Do we actually need any of these artifacts? If deleting this doesn't work either it would lead me to think that it might be another issue.

@dsherry
Copy link
Collaborator Author

dsherry commented Apr 8, 2020

Looks like this worked on our docs branch! @angela97lin you wanna approve this so we can get it in and update the feature branch?

Copy link
Contributor

@angela97lin angela97lin left a comment

YAY for build succeeding! :'D

@dsherry
Copy link
Collaborator Author

dsherry commented Apr 8, 2020

@jeremyliweishih yeah it seems sphinx is taking over double the time to build on the improved_docs feature branch. I don't understand why. Our theory is that it's because that branch adds 15-20 classes to the API ref. But that doesn't really explain why. We can fine tune that once we've got it into master.

@dsherry
Copy link
Collaborator Author

dsherry commented Apr 8, 2020

And yeah I think it'd important to keep some downloadable format. PDF is great.

@dsherry dsherry force-pushed the ds_docs_remove_htmlzip branch from f26e1a5 to f1f19e6 Compare Apr 8, 2020
@dsherry dsherry merged commit c4e294c into master Apr 8, 2020
2 checks passed
@dsherry dsherry deleted the ds_docs_remove_htmlzip branch Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing Issues related to testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants