-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop htmlzip download format from readthedocs, leaving only pdf #600
Conversation
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
===========================================
+ Coverage 84.39% 98.87% +14.48%
===========================================
Files 118 118
Lines 4453 4453
===========================================
+ Hits 3758 4403 +645
+ Misses 695 50 -645
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we actually need any of these artifacts? If deleting this doesn't work either it would lead me to think that it might be another issue.
Looks like this worked on our docs branch! @angela97lin you wanna approve this so we can get it in and update the feature branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAY for build succeeding! :'D
@jeremyliweishih yeah it seems sphinx is taking over double the time to build on the improved_docs feature branch. I don't understand why. Our theory is that it's because that branch adds 15-20 classes to the API ref. But that doesn't really explain why. We can fine tune that once we've got it into master. |
And yeah I think it'd important to keep some downloadable format. PDF is great. |
f26e1a5
to
f1f19e6
Compare
We're still seeing RTD timeouts on @angela97lin 's feature branch for #346 , so dropping down to PDF as our only download artifact.