Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows checkin tests: remove unneeded conda step for xgboost! #618

Merged
merged 5 commits into from Apr 11, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Apr 11, 2020

Windows py38 tests have been taking 19min to install xgboost using anaconda's py-xgboost package 馃挬

I tried using conda-forge's xgboost package but couldn't get it to work. But while it was broken I noticed the unit tests still passed... on further inspection, it appears the python xgboost package contains all that's necessary to run xgboost on windows! I.e. the conda install step is not required. That's great news :)

Also added some test coverage to update the xgboost pipeline tests. Sklearn is great but its also bloated... I had to dig through three files to find out what Pipeline.score does by default. For classification the answer is accuracy.

@dsherry dsherry force-pushed the ds_windows_conda_xgboost_update branch from 2d49dfa to b73fe5b Compare Apr 11, 2020
@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #618 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         118      118           
  Lines        4456     4458    +2     
=======================================
+ Hits         4407     4409    +2     
  Misses         49       49           
Impacted Files Coverage 螖
evalml/tests/pipeline_tests/test_xgboost.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 434e7e3...b73fe5b. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Sweeeet, am I reading this correctly--it now takes ~10 minutes to run the windows tests? 馃憦

@dsherry
Copy link
Collaborator Author

dsherry commented Apr 11, 2020

Yeah!!

@dsherry dsherry merged commit 892e344 into master Apr 11, 2020
2 checks passed
@dsherry dsherry deleted the ds_windows_conda_xgboost_update branch Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants