Update windows checkin tests: remove unneeded conda step for xgboost!#618
Merged
Conversation
dsherry
force-pushed
the
ds_windows_conda_xgboost_update
branch
from
2d49dfa to
b73fe5b
Compare
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 118 118
Lines 4456 4458 +2
=======================================
+ Hits 4407 4409 +2
Misses 49 49
Continue to review full report at Codecov.
|
angela97lin
approved these changes
Apr 11, 2020
Contributor
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
Sweeeet, am I reading this correctly--it now takes ~10 minutes to run the windows tests? 👏
Contributor
Author
|
Yeah!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows py38 tests have been taking 19min to install xgboost using anaconda's
py-xgboostpackage 💩I tried using conda-forge's
xgboostpackage but couldn't get it to work. But while it was broken I noticed the unit tests still passed... on further inspection, it appears the python xgboost package contains all that's necessary to run xgboost on windows! I.e. theconda installstep is not required. That's great news :)Also added some test coverage to update the xgboost pipeline tests. Sklearn is great but its also bloated... I had to dig through three files to find out what
Pipeline.scoredoes by default. For classification the answer is accuracy.