Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependencies from Makefile #637

Merged
merged 2 commits into from Apr 14, 2020
Merged

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Apr 14, 2020

Fixes #636.

Fixed:
Screen Shot 2020-04-14 at 12 43 46 PM

Before:
Screen Shot 2020-04-14 at 12 44 22 PM

@jeremyliweishih jeremyliweishih changed the title Remove circular dependencies from Makefile [WIP] Remove circular dependencies from Makefile Apr 14, 2020
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #637 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #637   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files         133      133           
  Lines        4545     4545           
=======================================
  Hits         4498     4498           
  Misses         47       47           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49026c8...d6fc5a5. Read the comment docs.

@jeremyliweishih jeremyliweishih changed the title [WIP] Remove circular dependencies from Makefile Remove circular dependencies from Makefile Apr 14, 2020
@jeremyliweishih jeremyliweishih requested a review from dsherry Apr 14, 2020
pip install -r test-requirements.txt -q

.PHONY: installdeps-dev
installdeps-dev: installdeps-dev
installdeps-dev:
Copy link
Collaborator

@dsherry dsherry Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lol! How did this sneak in? Wouldn't this break our build? I am unfamiliar with how make handles circular deps

Copy link
Contributor Author

@jeremyliweishih jeremyliweishih Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it breaks - it just ignores it

Copy link
Collaborator

@dsherry dsherry left a comment

👍 🚢

@jeremyliweishih jeremyliweishih merged commit 6f9d9f2 into master Apr 14, 2020
2 checks passed
@dsherry dsherry deleted the js_636_make branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make circular dependency
2 participants