Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set raise_error to default to True for AutoML classes #638

Merged
merged 14 commits into from Apr 15, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Apr 14, 2020

Closes #635

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #638 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         136      136           
  Lines        4685     4692    +7     
=======================================
+ Hits         4637     4644    +7     
  Misses         48       48           
Impacted Files Coverage Δ
evalml/automl/auto_base.py 96.36% <100.00%> (ø)
...ts/automl_tests/test_auto_classification_search.py 100.00% <100.00%> (ø)
.../tests/automl_tests/test_auto_regression_search.py 100.00% <100.00%> (ø)
evalml/tests/automl_tests/test_autobase.py 100.00% <100.00%> (ø)
...alml/tests/objective_tests/test_fraud_detection.py 100.00% <100.00%> (ø)
evalml/tests/objective_tests/test_lead_scoring.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243fed9...84df8b5. Read the comment docs.

@angela97lin angela97lin requested a review from dsherry Apr 14, 2020
evalml/automl/auto_base.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dsherry dsherry left a comment

Left a minor comment and a question, LGTM!

evalml/automl/auto_base.py Outdated Show resolved Hide resolved
@angela97lin angela97lin merged commit a3f0a26 into master Apr 15, 2020
2 checks passed
@angela97lin angela97lin deleted the 635_raise_error branch Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set raise_error to default to True for AutoML classes
2 participants