-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uint8 dtype for one hot encoded features instead of int #653
Conversation
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 136 136
Lines 4696 4697 +1
=======================================
+ Hits 4648 4649 +1
Misses 48 48
Continue to review full report at Codecov.
|
@angela97lin can you please move this and the attached issue to Review/QA |
@dsherry I usually want to wait until I see tests pass on CircleCI first, but will do right after :) |
@angela97lin ah ok! I asked because it said "marked for review". Got it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked a question but LGTM :)
Closes #614