Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uint8 dtype for one hot encoded features instead of int #653

Merged
merged 12 commits into from Apr 15, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Apr 15, 2020

Closes #614

@angela97lin angela97lin self-assigned this Apr 15, 2020
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #653 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         136      136           
  Lines        4696     4697    +1     
=======================================
+ Hits         4648     4649    +1     
  Misses         48       48           
Impacted Files Coverage Δ
...components/transformers/encoders/onehot_encoder.py 100.00% <100.00%> (ø)
...alml/tests/component_tests/test_one_hot_encoder.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495702c...6a8acf5. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review Apr 15, 2020
@dsherry
Copy link
Collaborator

dsherry commented Apr 15, 2020

@angela97lin can you please move this and the attached issue to Review/QA

@angela97lin
Copy link
Contributor Author

angela97lin commented Apr 15, 2020

@dsherry I usually want to wait until I see tests pass on CircleCI first, but will do right after :)

@angela97lin angela97lin requested a review from dsherry Apr 15, 2020
@dsherry
Copy link
Collaborator

dsherry commented Apr 15, 2020

@angela97lin ah ok! I asked because it said "marked for review". Got it 👍

Copy link
Collaborator

@dsherry dsherry left a comment

I asked a question but LGTM :)

@angela97lin angela97lin merged commit 77aac1e into master Apr 15, 2020
2 checks passed
@angela97lin angela97lin deleted the 614_ohe_uint8 branch Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use uint8 dtype for one hot encoding
2 participants