Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhide PR references in changelog #656

Merged
merged 6 commits into from
Apr 15, 2020
Merged

Unhide PR references in changelog #656

merged 6 commits into from
Apr 15, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Apr 15, 2020 •
edited
Loading

Closes #570

image

@codecov
Copy link

codecov bot commented Apr 15, 2020 •
edited
Loading

Codecov Report

Merging #656 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         136      136           
  Lines        4697     4697           
=======================================
  Hits         4649     4649           
  Misses         48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77aac1e...7fb472c. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review April 15, 2020 16:32
@angela97lin angela97lin self-assigned this Apr 15, 2020
dsherry
dsherry reviewed Apr 15, 2020
View reviewed changes
docs/source/changelog.rst Outdated Show resolved Hide resolved
dsherry
dsherry approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in changelog otherwise LGTM!

@angela97lin angela97lin merged commit ee53b84 into master Apr 15, 2020
@angela97lin angela97lin deleted the 570_pr_refs branch April 15, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR references don't show up in change log
2 participants
@angela97lin @dsherry