Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove graphs.py and remove separate plotting section from API reference #657

Merged
merged 7 commits into from Apr 16, 2020

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Apr 15, 2020

Fixes #549.

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #657 into master will decrease coverage by 0.36%.
The diff coverage is 95.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   98.97%   98.61%   -0.37%     
==========================================
  Files         136      135       -1     
  Lines        4697     4691       -6     
==========================================
- Hits         4649     4626      -23     
- Misses         48       65      +17     
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 97.66% <95.74%> (-0.60%) ⬇️
evalml/tests/utils_tests/test_dependencies.py 87.50% <0.00%> (-12.50%) ⬇️
evalml/tests/component_tests/test_utils.py 92.85% <0.00%> (-3.58%) ⬇️
.../tests/automl_tests/test_auto_regression_search.py 97.93% <0.00%> (-2.07%) ⬇️
evalml/tests/pipeline_tests/test_pipelines.py 97.87% <0.00%> (-1.77%) ⬇️
evalml/tests/component_tests/test_components.py 98.75% <0.00%> (-1.25%) ⬇️
evalml/automl/auto_base.py 95.37% <0.00%> (-1.00%) ⬇️
...ts/automl_tests/test_auto_classification_search.py 99.32% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e5553b...42e038e. Read the comment docs.

@jeremyliweishih jeremyliweishih marked this pull request as ready for review Apr 15, 2020
@jeremyliweishih jeremyliweishih requested a review from dsherry Apr 15, 2020
evalml/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
@dsherry
Copy link
Collaborator

dsherry commented Apr 15, 2020

@jeremyliweishih connect this PR with #549?

@jeremyliweishih jeremyliweishih requested a review from dsherry Apr 16, 2020
@@ -33,6 +34,7 @@ Changelog
* Update release process doc :pr:`567`
* AutoClassificationSearch and AutoRegressionSearch show inherited methods in API reference :pr:`651`
* Fixed improperly formatted code in breaking changes for changelog :pr:`655`
* Removed separate plotting section for pipelines in API reference :pr:`657`
Copy link
Collaborator

@dsherry dsherry Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Copy link
Collaborator

@dsherry dsherry left a comment

Yep, looks good!

@jeremyliweishih jeremyliweishih merged commit 2fcb148 into master Apr 16, 2020
0 of 2 checks passed
@dsherry
Copy link
Collaborator

dsherry commented Apr 16, 2020

Hey @jeremyliweishih I was about to comment: I just noticed the codecov was red. I bet it was just this exception handling that we don't have a mocking test for yet. You think you could get another PR up to add that?

@jeremyliweishih
Copy link
Contributor Author

jeremyliweishih commented Apr 16, 2020

@dsherry sure - I merged cause I didn't change any functionality and the codecov should be the exact same.

@dsherry
Copy link
Collaborator

dsherry commented Apr 16, 2020

@jeremyliweishih awesome, thanks, ood to have that coverage in place. Yeah, I guess the coverage threshold in the old file must've been high enough and moving it somehow slipped things.

@jeremyliweishih
Copy link
Contributor Author

jeremyliweishih commented Apr 16, 2020

Actually not too sure what to even add in - everything red on codecov is unrelated to this PR

https://codecov.io/gh/FeatureLabs/evalml/compare/6e5553bd6d462b9dafade8e8e57256e1d100530f...42e038e3bba4baf0645ee7b0c3093a3f15d4bce4/changes

@dsherry
Copy link
Collaborator

dsherry commented Apr 16, 2020

@jeremyliweishih yeah, the coverage change isn't the result of a problem with this PR. I think its simply that since you moved existing code into pipeline_base.py, that lowered overall coverage for that file. Specifically, here.

@jeremyliweishih
Copy link
Contributor Author

jeremyliweishih commented Apr 16, 2020

@dsherry got it makes sense!

@dsherry dsherry deleted the js_549_warn branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Documentation Warnings
2 participants