-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove graphs.py
and remove separate plotting section from API reference
#657
Conversation
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
==========================================
- Coverage 98.97% 98.61% -0.37%
==========================================
Files 136 135 -1
Lines 4697 4691 -6
==========================================
- Hits 4649 4626 -23
- Misses 48 65 +17
Continue to review full report at Codecov.
|
@jeremyliweishih connect this PR with #549? |
@@ -33,6 +34,7 @@ Changelog | |||
* Update release process doc :pr:`567` | |||
* AutoClassificationSearch and AutoRegressionSearch show inherited methods in API reference :pr:`651` | |||
* Fixed improperly formatted code in breaking changes for changelog :pr:`655` | |||
* Removed separate plotting section for pipelines in API reference :pr:`657` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks good!
Hey @jeremyliweishih I was about to comment: I just noticed the codecov was red. I bet it was just this exception handling that we don't have a mocking test for yet. You think you could get another PR up to add that? |
@dsherry sure - I merged cause I didn't change any functionality and the codecov should be the exact same. |
@jeremyliweishih awesome, thanks, ood to have that coverage in place. Yeah, I guess the coverage threshold in the old file must've been high enough and moving it somehow slipped things. |
Actually not too sure what to even add in - everything red on codecov is unrelated to this PR |
@jeremyliweishih yeah, the coverage change isn't the result of a problem with this PR. I think its simply that since you moved existing code into |
@dsherry got it makes sense! |
Fixes #549.