Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize components in API Reference #663

Merged
merged 22 commits into from Apr 21, 2020
Merged

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Apr 16, 2020

Closes #569. Also adds tiny description for each section per our docs discussion :)

You can see the updated docs here: https://evalml.featurelabs.com/en/569_categorize_components/api_reference.html

image

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #663 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         139      139           
  Lines        4934     4934           
=======================================
  Hits         4889     4889           
  Misses         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e953364...878bc8a. Read the comment docs.

@angela97lin angela97lin changed the title [WIP, Testing] Categorize components in API Reference Categorize components in API Reference Apr 21, 2020
@angela97lin angela97lin requested a review from dsherry Apr 21, 2020
@angela97lin angela97lin marked this pull request as ready for review Apr 21, 2020
docs/source/api_reference.rst Outdated Show resolved Hide resolved
docs/source/api_reference.rst Outdated Show resolved Hide resolved
docs/source/api_reference.rst Outdated Show resolved Hide resolved
Pipelines
~~~~~~~~~
Pipeline Base Classes
~~~~~~~~~~~~~~~~~~~~~
Copy link
Collaborator

@dsherry dsherry Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do the extra "~" here do?

Copy link
Contributor Author

@angela97lin angela97lin Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra squiggles for the new longer name (linter was complaining about duplicates since we have a heading and subheading both as Pipelines, so updated the latter)

Copy link
Collaborator

@dsherry dsherry left a comment

LGTM! Just don't forget to take a look at the final RTD build before merging :)

@angela97lin
Copy link
Contributor Author

angela97lin commented Apr 21, 2020

@dsherry Thanks for the doc suggestions! Updated, waiting for codecov and then will merge :)

@angela97lin
Copy link
Contributor Author

angela97lin commented Apr 21, 2020

@angela97lin angela97lin merged commit 297c077 into master Apr 21, 2020
2 checks passed
@angela97lin angela97lin deleted the 569_categorize_components branch Apr 21, 2020
@kmax12
Copy link
Contributor

kmax12 commented Apr 22, 2020

@angela97lin Like this a lot! one question - any reason we didn't add the Catboost classifier/regressor components? Oh and also the xgboost regressor seems to be missing

https://evalml.featurelabs.com/en/latest/api_reference.html#classifiers

@angela97lin
Copy link
Contributor Author

angela97lin commented Apr 22, 2020

@kmax12 No reason at all, seems like they were just missed. Going to open a new PR and fix this!

@angela97lin angela97lin restored the 569_categorize_components branch Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorize components in API Reference
3 participants