Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock error case for PipelineBase.graph #665

Merged
merged 3 commits into from Apr 16, 2020
Merged

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Apr 16, 2020

Patch for #549.

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #665 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   98.97%   99.02%   +0.04%     
==========================================
  Files         135      135              
  Lines        4702     4709       +7     
==========================================
+ Hits         4654     4663       +9     
+ Misses         48       46       -2     
Impacted Files Coverage Δ
evalml/tests/pipeline_tests/test_graphs.py 100.00% <100.00%> (ø)
evalml/pipelines/pipeline_base.py 98.59% <0.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b5d88a...39cf95e. Read the comment docs.

@jeremyliweishih jeremyliweishih marked this pull request as ready for review Apr 16, 2020
@jeremyliweishih jeremyliweishih requested a review from dsherry Apr 16, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

Love it. I like the same-line changelog entries too 👍

@jeremyliweishih jeremyliweishih merged commit f306797 into master Apr 16, 2020
2 checks passed
@dsherry dsherry deleted the js_549_patch branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants