Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Sphinx warnings about BalancedAccuracy, XGBoostRegressionPipeline, etc. #669

Merged
merged 7 commits into from Apr 17, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Apr 16, 2020

Fixes #667

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #669 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #669   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files         139      139           
  Lines        4907     4907           
=======================================
  Hits         4861     4861           
  Misses         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da6cb0...bfa60a8. Read the comment docs.

@angela97lin angela97lin changed the title Fixes Sphinx warnings about BalancedAccuracy Fixes Sphinx warnings Apr 17, 2020
@angela97lin angela97lin changed the title Fixes Sphinx warnings Fixes Sphinx warnings about BalancedAccuracy, XGBoostRegressionPipeline, etc. Apr 17, 2020
@angela97lin angela97lin marked this pull request as ready for review Apr 17, 2020
@angela97lin angela97lin requested a review from dsherry Apr 17, 2020
"leads_data = urlopen('https://featurelabs-static.s3.amazonaws.com/lead_scoring_ml_apps/previous_leads.csv')\n"
"customers_data = urlopen('https://featurelabs-static.s3.amazonaws.com/lead_scoring_ml_apps/customers.csv')\n",
"interactions_data = urlopen('https://featurelabs-static.s3.amazonaws.com/lead_scoring_ml_apps/interactions.csv')\n",
"leads_data = urlopen('https://featurelabs-static.s3.amazonaws.com/lead_scoring_ml_apps/previous_leads.csv')\n",
Copy link
Collaborator

@dsherry dsherry Apr 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nooo, my bad, thank you! I am going to sleep better knowing we have sphinx warnings failing builds from #660 haha

Copy link
Collaborator

@dsherry dsherry left a comment

👏 👏

@angela97lin angela97lin merged commit 0780284 into master Apr 17, 2020
2 checks passed
@angela97lin angela97lin deleted the 667_fix_sphinx_warnings branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Sphinx warnings for BalancedAccuracy objective
2 participants