Suppress UndefinedMetric Warning for F1/precision/recall #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd F1 tests. Updated changelog.
dsherry
force-pushed
the
ds_436_suppress_undefinedmetric
branch
from
11341f5
to
3494584
Compare
dsherry
commented
Apr 17, 2020
| @@ -47,15 +47,14 @@ def objective_function(self, y_predicted, y_true, X=None): | |||
| return metrics.balanced_accuracy_score(y_true, y_predicted) | |||
|
|
|||
|
|
|||
| # todo does this need tuning? | |||
There was a problem hiding this comment.
Not directly related to this PR but I just noticed this and thought it should be deleted. FYI @kmax12
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
+ Coverage 99.04% 99.05% +0.01%
==========================================
Files 139 139
Lines 4810 4882 +72
==========================================
+ Hits 4764 4836 +72
Misses 46 46
Continue to review full report at Codecov.
|
angela97lin
approved these changes
Apr 17, 2020
|
@angela97lin yep! I added more test coverage for the objectives affected by this PR. I hope we can follow this pattern with all the objectives we add eventually. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #436 , builds off #588 .
These warnings occur when the denominator in the computation of these quantities is 0. In that case we should just return 0 F1/precision/recall and not warn. Sklearn by default returns 0 but also warns.