Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accuracy Multiclass #672

Merged
merged 5 commits into from Apr 17, 2020
Merged

Add Accuracy Multiclass #672

merged 5 commits into from Apr 17, 2020

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Apr 17, 2020

Pull Request Description

@gsheni gsheni self-assigned this Apr 17, 2020
@gsheni gsheni requested a review from angela97lin Apr 17, 2020
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #672 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #672   +/-   ##
=======================================
  Coverage   99.05%   99.06%           
=======================================
  Files         139      139           
  Lines        4882     4907   +25     
=======================================
+ Hits         4836     4861   +25     
  Misses         46       46           
Impacted Files Coverage Δ
evalml/objectives/__init__.py 100.00% <ø> (ø)
evalml/objectives/utils.py 94.44% <ø> (ø)
...lines/components/estimators/regressors/__init__.py 100.00% <ø> (ø)
evalml/pipelines/regression/__init__.py 100.00% <ø> (ø)
evalml/objectives/standard_metrics.py 99.56% <100.00%> (+0.01%) ⬆️
evalml/tests/objective_tests/test_objectives.py 96.29% <100.00%> (ø)
...lml/tests/objective_tests/test_standard_metrics.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1273b44...832df11. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Just a few minor comments but otherwise LGTM! Pretty cool that we don't have to change the implementation for multiclass! :)

docs/source/api_reference.rst Outdated Show resolved Hide resolved
evalml/objectives/utils.py Outdated Show resolved Hide resolved
evalml/tests/objective_tests/test_standard_metrics.py Outdated Show resolved Hide resolved
@dsherry
Copy link
Collaborator

dsherry commented Apr 17, 2020

@gsheni check out the pattern I introduced for these unit tests in #671 , which I just merged and which you'll see once you update your branch.

Also, please attach this PR to #626 , helps with tracking.

Copy link
Collaborator

@dsherry dsherry left a comment

LGTM, thanks for adding. Please do mirror the tests I just added to master.

@gsheni gsheni force-pushed the add_accuracy_binary_multi branch from f72491f to 101e18a Compare Apr 17, 2020
@gsheni
Copy link
Member Author

gsheni commented Apr 17, 2020

@dsherry What do you mean? I did link the issue on the right hand side
Screen Shot 2020-04-17 at 10 44 27 AM

@dsherry
Copy link
Collaborator

dsherry commented Apr 17, 2020

@gsheni good question. Check the bottom just above the comments box. When you do "connect with an issue" there, it will connect the PR and parent ticket in zenhub. It helps keep the zenhub board clean.
Screen Shot 2020-04-17 at 10 52 50 AM

@gsheni gsheni merged commit 4da6cb0 into master Apr 17, 2020
2 checks passed
@gsheni gsheni deleted the add_accuracy_binary_multi branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Balanced Accuracy and Accuracy to MultiClassificationObjective
3 participants