Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ModelFamily xgboost/catboost values #677

Merged
merged 3 commits into from Apr 20, 2020
Merged

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Apr 18, 2020

Fix #676

Specifically, xgboost and catboost should not say "classifier" as we have regressor pipelines for them.

@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #677 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         139      139           
  Lines        4933     4933           
=======================================
  Hits         4888     4888           
  Misses         45       45           
Impacted Files Coverage Δ
evalml/model_family/model_family.py 100.00% <ø> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8642ca...fafca1b. Read the comment docs.

@dsherry dsherry marked this pull request as ready for review Apr 20, 2020
@dsherry dsherry requested a review from angela97lin Apr 20, 2020
@dsherry dsherry changed the title [WIP] Update ModelFamily xgboost/catboost values Update ModelFamily xgboost/catboost values Apr 20, 2020
Copy link
Contributor

@angela97lin angela97lin left a comment

LGTM 🚢

@dsherry dsherry merged commit 70d6821 into master Apr 20, 2020
2 checks passed
@dsherry dsherry deleted the ds_676_modelfamily branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ModelFamily xgboost/catboost dict values to not say "Classifier"
2 participants