Replace pipelines' supported_problem_types' with 'problem_type' in base classes #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherry
changed the title
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
+ Coverage 99.07% 99.08% +0.01%
==========================================
Files 139 139
Lines 4963 4933 -30
==========================================
- Hits 4917 4888 -29
+ Misses 46 45 -1
Continue to review full report at Codecov.
|
dsherry
changed the title
dsherry
force-pushed
the
ds_668_remove_supported_problem_types
branch
from
7fc2597 to
346f339
Compare
jeremyliweishih
approved these changes
Apr 20, 2020
| @@ -24,13 +24,12 @@ | |||
| "objective = 'Precision_Macro'\n", | |||
| "\n", | |||
| "\n", | |||
| "# pipeline needs to be a subclass of `PipelineBase`\n", | |||
| "class CustomPipeline(PipelineBase):\n", | |||
| "# the pipeline needs to be a subclass of one of our base pipelines, in this case `BinaryClassificationPipeline`\n", | |||
There was a problem hiding this comment.
typo here - should be multiclass
There was a problem hiding this comment.
Ah good catch, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #668
Now that we have
BinaryClassificationPipeline,MultiClassificationPipelineandRegressionPipeline, we don't need pipelines to support a list of problem types. The base classes can set the problem type for internal use, but otherwise users don't need to know about it.