Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pipelines' supported_problem_types' with 'problem_type' in base classes #678

Merged
merged 10 commits into from Apr 20, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Apr 18, 2020

Fixes #668

Now that we have BinaryClassificationPipeline, MultiClassificationPipeline and RegressionPipeline, we don't need pipelines to support a list of problem types. The base classes can set the problem type for internal use, but otherwise users don't need to know about it.

@dsherry dsherry changed the title Replace pipelines' supported_problem_types' with 'problem_type' in base classes [WIP] Replace pipelines' supported_problem_types' with 'problem_type' in base classes Apr 18, 2020
@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #678 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   99.07%   99.08%   +0.01%     
==========================================
  Files         139      139              
  Lines        4963     4933      -30     
==========================================
- Hits         4917     4888      -29     
+ Misses         46       45       -1     
Impacted Files Coverage Δ
evalml/pipelines/regression/catboost.py 100.00% <ø> (ø)
evalml/pipelines/regression/linear_regression.py 100.00% <ø> (ø)
evalml/pipelines/regression/random_forest.py 100.00% <ø> (ø)
evalml/pipelines/binary_classification_pipeline.py 100.00% <100.00%> (ø)
...ml/pipelines/multiclass_classification_pipeline.py 100.00% <100.00%> (ø)
evalml/pipelines/pipeline_base.py 99.03% <100.00%> (+0.43%) ⬆️
evalml/pipelines/regression_pipeline.py 100.00% <100.00%> (ø)
evalml/pipelines/utils.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_graphs.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.62% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fedf24d...2050bb7. Read the comment docs.

@dsherry dsherry marked this pull request as ready for review Apr 20, 2020
@dsherry dsherry requested a review from jeremyliweishih Apr 20, 2020
@dsherry dsherry changed the title [WIP] Replace pipelines' supported_problem_types' with 'problem_type' in base classes Replace pipelines' supported_problem_types' with 'problem_type' in base classes Apr 20, 2020
@dsherry dsherry force-pushed the ds_668_remove_supported_problem_types branch from 7fc2597 to 346f339 Compare Apr 20, 2020
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

LGTM just one typo!

@@ -24,13 +24,12 @@
"objective = 'Precision_Macro'\n",
"\n",
"\n",
"# pipeline needs to be a subclass of `PipelineBase`\n",
"class CustomPipeline(PipelineBase):\n",
"# the pipeline needs to be a subclass of one of our base pipelines, in this case `BinaryClassificationPipeline`\n",
Copy link
Contributor

@jeremyliweishih jeremyliweishih Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here - should be multiclass

Copy link
Collaborator Author

@dsherry dsherry Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, thanks!

@dsherry dsherry merged commit b8642ca into master Apr 20, 2020
2 checks passed
@dsherry dsherry deleted the ds_668_remove_supported_problem_types branch Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove supported_problem_types in favor of pipeline subclasses
2 participants