-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show best results for a given pipeline template in rankings #682
Conversation
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
=======================================
Coverage 99.08% 99.09%
=======================================
Files 139 139
Lines 4934 4947 +13
=======================================
+ Hits 4889 4902 +13
Misses 45 45
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Left some comments and questions
assert isinstance(automl.best_pipeline, PipelineBase) | ||
assert isinstance(automl.get_pipeline(0), PipelineBase) | ||
|
||
automl.describe_pipeline(0) | ||
|
||
scores = automl.best_pipeline.score(X, y, ['precision']) | ||
assert not any(np.isnan(val) for val in scores.values()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I think you can also do assert not np.isnan(np.array(scores.values())).any()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried and I think it would be assert not np.isnan(np.array(list(scores.values()))).any()
, not sure if there's a clear better statement here :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol no worries, was just a passing comment. I've found numpy methods to generally be faster than the python builtins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one more suggestion, otherwise 🚢 !
Closes #410