Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize import_or_raise error messages #683

Merged
merged 2 commits into from Apr 21, 2020
Merged

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Apr 20, 2020

Closes #520

@angela97lin angela97lin self-assigned this Apr 20, 2020
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #683 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #683   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         139      139           
  Lines        4933     4934    +1     
=======================================
+ Hits         4888     4889    +1     
  Misses         45       45           
Impacted Files Coverage Δ
evalml/tests/utils_tests/test_gen_utils.py 100.00% <100.00%> (ø)
evalml/utils/gen_utils.py 98.30% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d6821...9996c0f. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review Apr 21, 2020
@angela97lin angela97lin requested review from dsherry and kmax12 Apr 21, 2020
kmax12
kmax12 approved these changes Apr 21, 2020
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM

@angela97lin angela97lin merged commit 9c502f1 into master Apr 21, 2020
2 checks passed
@angela97lin angela97lin deleted the 520_standarize_import branch Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize import_or_raise error messages
2 participants