Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change automl's describe_pipeline to get problem type from pipeline instead #685

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Change automl's describe_pipeline to get problem type from pipeline instead #685

merged 3 commits into from
Apr 21, 2020

Conversation

angela97lin
Copy link
Contributor

Closes #684

@angela97lin angela97lin self-assigned this Apr 21, 2020
@codecov
Copy link

codecov bot commented Apr 21, 2020 •
edited
Loading

Codecov Report

Merging #685 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #685   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         139      139           
  Lines        4934     4934           
=======================================
  Hits         4889     4889           
  Misses         45       45
Impacted Files Coverage Δ
evalml/automl/auto_base.py 96.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c502f1...41990aa. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review April 21, 2020 18:57
dsherry
dsherry reviewed Apr 21, 2020
View reviewed changes
evalml/automl/auto_base.py
@@ -416,8 +416,7 @@ def describe_pipeline(self, pipeline_id, return_dict=False):

pipeline.describe()
logger.log_subtitle("Training")
# Ideally, we want this information available on pipeline instead
logger.log("Training for {} problems.".format(self.problem_type))
logger.log("Training for {} problems.".format(pipeline.problem_type))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

dsherry
dsherry approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@angela97lin angela97lin merged commit e953364 into master Apr 21, 2020
@angela97lin angela97lin deleted the change_automl_describe_ange branch April 21, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change automl's describe_pipeline to get problem type from pipeline instead
2 participants
@angela97lin @dsherry