Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document evalml/preprocessing/ code #687

Merged
merged 9 commits into from Apr 24, 2020
Merged

Document evalml/preprocessing/ code #687

merged 9 commits into from Apr 24, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Apr 21, 2020

Closes #393

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #687 into master will increase coverage by 11.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #687       +/-   ##
===========================================
+ Coverage   87.78%   99.09%   +11.30%     
===========================================
  Files         139      139               
  Lines        4954     4954               
===========================================
+ Hits         4349     4909      +560     
+ Misses        605       45      -560     
Impacted Files Coverage Δ
evalml/preprocessing/utils.py 100.00% <ø> (ø)
evalml/tests/component_tests/test_components.py 100.00% <0.00%> (+0.60%) ⬆️
evalml/automl/auto_base.py 96.42% <0.00%> (+0.97%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.62% <0.00%> (+3.39%) ⬆️
evalml/tests/component_tests/test_utils.py 96.42% <0.00%> (+3.57%) ⬆️
evalml/pipelines/pipeline_base.py 99.03% <0.00%> (+5.79%) ⬆️
evalml/tests/utils_tests/test_dependencies.py 100.00% <0.00%> (+6.25%) ⬆️
...ts/automl_tests/test_auto_classification_search.py 100.00% <0.00%> (+15.66%) ⬆️
.../tests/automl_tests/test_auto_regression_search.py 100.00% <0.00%> (+25.77%) ⬆️
evalml/tests/pipeline_tests/test_graphs.py 100.00% <0.00%> (+26.02%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c994d60...3bc249f. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review Apr 23, 2020
@angela97lin angela97lin requested a review from dsherry Apr 23, 2020
@dsherry
Copy link
Collaborator

dsherry commented Apr 23, 2020

@angela97lin reminder to please move to Review when you request a review!

evalml/preprocessing/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dsherry dsherry left a comment

One error but otherwise lgtm!

@angela97lin angela97lin merged commit fe7e929 into master Apr 24, 2020
2 checks passed
@angela97lin angela97lin deleted the 393_preprocessing branch Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document evalml/preprocessing/ code
2 participants