-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to API doc #688
Updates to API doc #688
Conversation
0951a8c
to
60140c5
Compare
@@ -30,7 +30,7 @@ Preprocessing | |||
split_data | |||
|
|||
|
|||
.. currentmodule:: evalml | |||
.. currentmodule:: evalml.automl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary, since we import the automl classes in evalml/__init__.py
, but it's nice to be consistent with the other usages in this file
MulticlassClassificationPipeline | ||
RegressionPipeline | ||
|
||
Classification Pipelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All I changed was adding the word "Pipelines" here and for regression. Otherwise these changes should all be from moving
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 139 139
Lines 4953 4953
=======================================
Hits 4908 4908
Misses 45 45 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM here (https://evalml.featurelabs.com/en/ds_update_pipeline_api_doc/api_reference.html)! I'm not sure what the python 3.7 failure is about though, and the build docs seem to have failed (I triggered a build after)
docs/source/api_reference.rst
Outdated
.. currentmodule:: evalml.objectives | ||
|
||
Plot Metrics | ||
~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use "============"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might not matter - we had that before as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh - got it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I see that now. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I retriggered the 3.7 test - I've seen this happen before and re running tests usually fixes it.
@jeremyliweishih thanks. Yeah, something's been going on with the checkin jobs lately. I've noticed some random timeouts. I suspect it's a circleci issue... |
@angela97lin just added titles to the components and while reviewing that I thought of some other changes which would help.
Changes to API ref: