Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move install out of Quick Start #701

Merged
merged 8 commits into from
Apr 24, 2020
Merged

Move install out of Quick Start #701

merged 8 commits into from
Apr 24, 2020

Conversation

jeremyliweishih
Copy link
Collaborator

@jeremyliweishih jeremyliweishih commented Apr 23, 2020 •
edited
Loading

Fixes #521.

Screen Shot 2020-04-23 at 2 01 20 PM

@codecov
Copy link

codecov bot commented Apr 23, 2020 •
edited
Loading

Codecov Report

Merging #701 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #701   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         139      139           
  Lines        4954     4954           
=======================================
  Hits         4909     4909           
  Misses         45       45
Impacted Files Coverage Δ
evalml/preprocessing/utils.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b12e5fa...c2ae29a. Read the comment docs.

@jeremyliweishih jeremyliweishih requested a review from dsherry April 23, 2020 18:02
dsherry
dsherry reviewed Apr 23, 2020
View reviewed changes
docs/source/install.ipynb Outdated Show resolved Hide resolved
dsherry
dsherry reviewed Apr 23, 2020
View reviewed changes
docs/source/install.ipynb Outdated Show resolved Hide resolved
dsherry
dsherry reviewed Apr 23, 2020
View reviewed changes
docs/source/install.ipynb Outdated Show resolved Hide resolved
dsherry
dsherry reviewed Apr 23, 2020
View reviewed changes
docs/source/install.ipynb Outdated Show resolved Hide resolved
dsherry
dsherry reviewed Apr 23, 2020
View reviewed changes
docs/source/index.ipynb Outdated Show resolved Hide resolved
dsherry
dsherry approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments but LGTM! Thank you :)

@dsherry
Copy link
Contributor

dsherry commented Apr 23, 2020

Oh and please do make sure RTD is green before merging, to make sure I actually closed #702

@dsherry
Copy link
Contributor

dsherry commented Apr 24, 2020

@jeremyliweishih is this waiting on anything to merge? Looks like RTD passed yesterday.

@jeremyliweishih
Copy link
Collaborator Author

@dsherry just finished addressing your comments!

@jeremyliweishih jeremyliweishih merged commit 09da1e6 into master Apr 24, 2020
@dsherry dsherry deleted the js_521_install branch October 29, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

Assignees

@jeremyliweishih jeremyliweishih

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create install page in documentation
2 participants
@jeremyliweishih @dsherry