Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pipeline Docs #705

Merged
merged 10 commits into from
Apr 26, 2020
Merged

Update Pipeline Docs #705

merged 10 commits into from
Apr 26, 2020

Conversation

jeremyliweishih
Copy link
Collaborator

@jeremyliweishih jeremyliweishih commented Apr 23, 2020

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #705 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         140      140           
  Lines        4985     4985           
=======================================
  Hits         4946     4946           
  Misses         39       39           
Impacted Files Coverage Δ
...lml/pipelines/classification/xgboost_multiclass.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b97ed0...afa60fa. Read the comment docs.

@jeremyliweishih jeremyliweishih requested a review from dsherry April 24, 2020 16:21
@jeremyliweishih jeremyliweishih marked this pull request as ready for review April 24, 2020 16:35
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremyliweishih nice work, this is awesome!! I left a bunch of suggestions building off what you have. In particular, I'd like us to have more short code snippets instead of having pages with a description and then one huge code snippet at the bottom. This will help hold people's attention better, I think.

@jeremyliweishih jeremyliweishih merged commit 72ca338 into master Apr 26, 2020
@dsherry dsherry deleted the js_631_custom branch October 29, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure our custom pipeline documentation is complete
2 participants