Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MultiClassificationObjective to MulticlassClassificationObjective #715

Merged
merged 4 commits into from Apr 25, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Apr 24, 2020

Changes:

  • Renamed MultiClassificationObjective to MulticlassClassificationObjective, to align with pipeline naming scheme
  • Remove hyphen from multiclass in two places

@dsherry dsherry added refactor Work being done to refactor code. documentation Improvements or additions to documentation labels Apr 24, 2020
@dsherry dsherry added this to the April 2020 milestone Apr 24, 2020
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #715 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         140      140           
  Lines        4985     4985           
=======================================
  Hits         4946     4946           
  Misses         39       39           
Impacted Files Coverage Δ
evalml/objectives/__init__.py 100.00% <100.00%> (ø)
.../objectives/multiclass_classification_objective.py 100.00% <100.00%> (ø)
evalml/objectives/standard_metrics.py 100.00% <100.00%> (ø)
...pelines/classification/random_forest_multiclass.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388299a...2fe3002. Read the comment docs.

@dsherry dsherry force-pushed the ds_multiclass_objective_rename branch from 6656bda to 820b3ce Compare Apr 24, 2020
@dsherry dsherry force-pushed the ds_multiclass_objective_rename branch from 820b3ce to 2fe3002 Compare Apr 24, 2020
Copy link
Contributor

@angela97lin angela97lin left a comment

LGTM! Thanks for this; I had considered MulticlassClassificationObjective but it just seemed too long, lolol

@dsherry
Copy link
Collaborator Author

dsherry commented Apr 25, 2020

@angela97lin no prob! Yeah I just noticed this and figured it would be good to have the names align before we do a release, and wanted to hear what you all thought about it. Sounds good, will merge!

@dsherry dsherry merged commit fafb0e8 into master Apr 25, 2020
2 checks passed
@dsherry dsherry deleted the ds_multiclass_objective_rename branch Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactor Work being done to refactor code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants