Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency update PR exception for changelog test #723

Merged
merged 6 commits into from Apr 27, 2020

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Apr 27, 2020

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #723 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #723   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         140      140           
  Lines        4985     4985           
=======================================
  Hits         4946     4946           
  Misses         39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052727c...9710c6b. Read the comment docs.

@jeremyliweishih jeremyliweishih marked this pull request as ready for review Apr 27, 2020
@jeremyliweishih jeremyliweishih requested a review from dsherry Apr 27, 2020
@@ -193,14 +193,18 @@ jobs:
- run: | # debugging info
if [[ $(expr match "${CIRCLE_BRANCH}" "release_v[0-9.]\+") -gt 0 ]]; then
echo This is a release PR;
elif [[ "${CIRCLE_BRANCH}" = "dep-update" ]]; then
Copy link
Collaborator

@dsherry dsherry Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, so we're special-casing this branch? That seems fine to me.

Is there any documentation we should add to this, perhaps in contributing.md? Not sure if there's a good place for that right now. Maybe unnecessary

Copy link
Contributor Author

@jeremyliweishih jeremyliweishih Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good place for now!

else
echo This is not a release PR;
echo This is a regular PR;
Copy link
Collaborator

@dsherry dsherry Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I had forgotten I introduced this pattern of duplicating this code across debug vs actual blocks.

Now that this is growing in complexity, could we move these echo statements down into the lower if/elif/else?

Copy link
Collaborator

@dsherry dsherry left a comment

Left two comments but otherwise LGTM!

@jeremyliweishih jeremyliweishih merged commit dda174f into master Apr 27, 2020
2 checks passed
@dsherry dsherry deleted the js_680_checkin branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog checkin test: skip for the dependency update bot PRs
2 participants