Add dependency update PR exception for changelog test #723
Conversation
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 140 140
Lines 4985 4985
=======================================
Hits 4946 4946
Misses 39 39 Continue to review full report at Codecov.
|
| @@ -193,14 +193,18 @@ jobs: | |||
| - run: | # debugging info | |||
| if [[ $(expr match "${CIRCLE_BRANCH}" "release_v[0-9.]\+") -gt 0 ]]; then | |||
| echo This is a release PR; | |||
| elif [[ "${CIRCLE_BRANCH}" = "dep-update" ]]; then | |||
There was a problem hiding this comment.
Got it, so we're special-casing this branch? That seems fine to me.
Is there any documentation we should add to this, perhaps in contributing.md? Not sure if there's a good place for that right now. Maybe unnecessary
There was a problem hiding this comment.
That seems like a good place for now!
| else | ||
| echo This is not a release PR; | ||
| echo This is a regular PR; |
There was a problem hiding this comment.
Ah, I had forgotten I introduced this pattern of duplicating this code across debug vs actual blocks.
Now that this is growing in complexity, could we move these echo statements down into the lower if/elif/else?
Fixes #680. Test with current branch.