Remove pass for abstract methods for codecov
#730
Conversation
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
==========================================
+ Coverage 99.07% 99.29% +0.21%
==========================================
Files 140 140
Lines 4992 4981 -11
==========================================
Hits 4946 4946
+ Misses 46 35 -11
Continue to review full report at Codecov.
|
angela97lin
changed the title
pass for abstract method for codecovpass for abstract methods for codecov
|
@dsherry Looks like we might need to remove the |
| @@ -11,7 +11,7 @@ class Estimator(ComponentBase): | |||
| @classmethod | |||
| @abstractmethod | |||
| def supported_problem_types(cls): | |||
| pass | |||
| """Problem types this estimator supports""" | |||
There was a problem hiding this comment.
@angela97lin oh I see this PR increased codecov a bit. So that means using pass in the last PR didn't actually change anything? 😂 Yeah this looks great. Thanks for following up on this!
|
@dsherry Yeah, looks like |
|
@angela97lin yeah, that's so weird. I now see the failed codecov master run you're talking about. Glad we've fixed it. Actually, this is making me think there's a problem with the codecov bot for the PR checkin tests. I'm going to file an issue for that. |
|
@angela97lin : I filed #731 for this issue |
Although using
passfor abstract methods allowed codecov to pass on my branch for #711, it seems to have caused codecov tests to fail on master.