Delete codecov yaml #732
Merged
Delete codecov yaml #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherry
added
bug
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 140 140
Lines 4981 4981
=======================================
Hits 4946 4946
Misses 35 35 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to codecov.io, we shouldn't name our codecov yaml
.codecov.yml. In fact, we should probably just use their default config, which isn't too different from our current config, meaning we don't need one. Thanks to @rwedge for the tip.I'm hoping this will help with #731 but I think there's more to the problem. We'll see!