Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete codecov yaml #732

Merged
merged 2 commits into from Apr 28, 2020
Merged

Delete codecov yaml #732

merged 2 commits into from Apr 28, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Apr 28, 2020

According to codecov.io, we shouldn't name our codecov yaml .codecov.yml. In fact, we should probably just use their default config, which isn't too different from our current config, meaning we don't need one. Thanks to @rwedge for the tip.

I'm hoping this will help with #731 but I think there's more to the problem. We'll see!

@dsherry dsherry added bug Issues tracking problems with existing features. testing Issues related to testing. labels Apr 28, 2020
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #732 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #732   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         140      140           
  Lines        4981     4981           
=======================================
  Hits         4946     4946           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dada93...d7516c9. Read the comment docs.

@dsherry dsherry marked this pull request as ready for review Apr 28, 2020
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Nice find!

@dsherry dsherry merged commit bdb59f7 into master Apr 28, 2020
2 checks passed
@dsherry dsherry deleted the ds_731_delete_codecov_yml branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues tracking problems with existing features. testing Issues related to testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants