Expanded import_or_raise to catch all exceptions
#759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
=======================================
Coverage 99.38% 99.38%
=======================================
Files 151 151
Lines 5532 5545 +13
=======================================
+ Hits 5498 5511 +13
Misses 34 34
Continue to review full report at Codecov.
|
angela97lin
reviewed
May 8, 2020
angela97lin
reviewed
May 8, 2020
dsherry
reviewed
May 8, 2020
| @@ -20,6 +20,9 @@ def import_or_raise(library, error_msg=None): | |||
| error_msg = "" | |||
| msg = (f"Missing optional dependency '{library}'. Please use pip to install {library}. {error_msg}") | |||
| raise ImportError(msg) | |||
| except Exception as ex: | |||
| msg = (f"An exception occured while trying to import `{library}`: {str(ex)}") | |||
| raise Exception(msg) | |||
There was a problem hiding this comment.
Looks good. This will be a great place to add some logging once @angela97lin's work adds it!
christopherbunn
force-pushed
the
729_add_ex_to_raise_or_import
branch
from
0d2ac84
to
1a8dba2
Compare
christopherbunn
force-pushed
the
729_add_ex_to_raise_or_import
branch
from
1a8dba2
to
8c83915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #729