Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to codecov 2.1.0 to fix codecov issues #782

Merged
merged 2 commits into from
May 18, 2020
Merged

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented May 18, 2020

Support recommended this, appears to have worked for featuretools!

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #782 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files         151      151           
  Lines        5545     5545           
=======================================
  Hits         5511     5511           
  Misses         34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0a24f...f0803e2. Read the comment docs.

@rwedge
Copy link
Contributor

rwedge commented May 18, 2020

codecov bot reported 600 misses and then promptly changed its mind 👀

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaaay!

@dsherry dsherry merged commit 93f86af into master May 18, 2020
@dsherry dsherry deleted the ds_781_codecov branch May 18, 2020 20:28
@dsherry dsherry mentioned this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants