This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kmax12@jeremyliweishih@angela97lin this PR is currently missing some more docstrings, a few more unit tests, and general documentation updates. I will get that stuff in shortly. But otherwise this is ready for review.
Just spoke with @kmax12 . Plan is that I'll address most of his comments, then extend the IterativeAlgorithm to be able to continue indefinitely and to respect max_pipelines, because we feel that's the most useful. There's a risk that will take too long for us to get it into the release tomorrow; if that happens we can always cut another next week.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.