Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CatBoost eta bug #795

Merged
merged 3 commits into from May 27, 2020
Merged

CatBoost eta bug #795

merged 3 commits into from May 27, 2020

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented May 21, 2020

Closes #791 - the bug was fixed easily by just increasing the lower bound of CatBoost regression from 0 to 0.00001. This also applies to XGBoost, since there was the possibility of the same error there.

@eccabay eccabay changed the title Increase components eta lower bound from 0 to 0.000001 CatBoost eta bug May 21, 2020
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #795 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #795   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files         150      150           
  Lines        5843     5843           
=======================================
  Hits         5815     5815           
  Misses         28       28           
Impacted Files Coverage Δ
...ents/estimators/classifiers/catboost_classifier.py 100.00% <ø> (ø)
...nents/estimators/classifiers/xgboost_classifier.py 100.00% <ø> (ø)
...onents/estimators/regressors/catboost_regressor.py 100.00% <ø> (ø)
...ponents/estimators/regressors/xgboost_regressor.py 100.00% <ø> (ø)
evalml/pipelines/utils.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5affa...df4f559. Read the comment docs.

@eccabay eccabay marked this pull request as ready for review May 22, 2020
@eccabay eccabay requested review from jeremyliweishih and dsherry May 22, 2020
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

LGTM :shipit:

@eccabay eccabay merged commit e533d14 into master May 27, 2020
2 checks passed
@dsherry dsherry deleted the 791_catboost_lr branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CatBoost learning rate can be 0
2 participants