Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps bot: create new branches using a suffix #817

Merged
merged 2 commits into from May 28, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented May 27, 2020

@jeremyliweishih and I have been debugging an issue with our dependency update bot. Here's more info on that.

This PR updates the create PR plugin we use to point to a new branch instead of using the same one every time.

@dsherry dsherry added bug Issues tracking problems with existing features. testing Issues related to testing. labels May 27, 2020
@dsherry dsherry requested a review from jeremyliweishih May 27, 2020
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #817 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files         159      159           
  Lines        6257     6257           
=======================================
  Hits         6227     6227           
  Misses         30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb1350...3e6fba8. Read the comment docs.

@dsherry dsherry changed the title Don't delete the branch when done; create new branches using a suffix Update deps bot: create new branches using a suffix May 27, 2020
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

🚢

@dsherry
Copy link
Collaborator Author

dsherry commented May 28, 2020

Let's see what happens!

@dsherry dsherry merged commit 68b9ef4 into master May 28, 2020
2 checks passed
@dsherry dsherry deleted the ds_update_deps_bot branch May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues tracking problems with existing features. testing Issues related to testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants