This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was there an offline discussion where we decide whether or not to treat this a new component?
my initial inclination would be to just add support in our current imputer to pass a dictionary of columns names to the current strategy method, but i would be curious to discuss.
@kmax12 Not yet - I went with this approach first since there will be complications with having input defined hyperparameter ranges (in this case column names or index of columns) but happy to discuss!
@kmax12: after speaking to @dsherry we agreed on having the PerColumnImputer as a separate component for two reasons.
If we were to replace SimpleImputer, we would need to design and discuss how automl and tuners accept input (number of columns etc.) as factors to consider. This can be done outside the scope of this PR.
The purpose of creating this component would to be used in EvalML pipelines and outside the scope of automl.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.