This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RE my questions: It'd be nice to support np.arrays and pd.DataFrames without specific string names by using indices or in the case of DataFrames, integer column names. Looks like unnamed columns are basically integer column names, so I don't see anything wrong with choosing a specific column by its index? Or at least I don't see it being unintuitive enough that we should just error out 🤔 What do you think? What confusion are you worried this may cause?
@angela97lin yeah, makes sense. I like the idea of having that support. My concern is that pandas DFs can sometimes have a custom index set up. And that adding support for that case increases complexity, will need more unit testing. If you wanna add it, it would definitely be useful, but consider doing it in a separate PR so we can get this merged first.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.