Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds drop null columns preprocessing component #834

Merged
merged 11 commits into from Jun 8, 2020
Merged

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Jun 3, 2020

Closes #833

@angela97lin angela97lin marked this pull request as draft Jun 3, 2020
@angela97lin angela97lin self-assigned this Jun 3, 2020
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #834 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #834   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files         188      191    +3     
  Lines        7338     7428   +90     
=======================================
+ Hits         7314     7404   +90     
  Misses         24       24           
Impacted Files Coverage Δ
evalml/pipelines/components/__init__.py 100.00% <ø> (ø)
...alml/pipelines/components/transformers/__init__.py 100.00% <100.00%> (ø)
.../components/transformers/preprocessing/__init__.py 100.00% <100.00%> (ø)
...ts/transformers/preprocessing/drop_null_columns.py 100.00% <100.00%> (ø)
...ponent_tests/test_drop_null_columns_transformer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7401a58...d03c142. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review Jun 4, 2020
@angela97lin angela97lin requested review from kmax12 and dsherry Jun 4, 2020
kmax12
kmax12 approved these changes Jun 4, 2020
Copy link
Contributor

@kmax12 kmax12 left a comment

did a quick pass. should get one more approval before merging

kmax12
kmax12 approved these changes Jun 5, 2020
dsherry
dsherry approved these changes Jun 8, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

Unit tests look great! I left a couple questions, one about making _cols_to_drop private and another about the boundary condition. But this looks ready to merge! We can finish those discussions and update if necessary.

@angela97lin angela97lin merged commit 167d1ed into master Jun 8, 2020
2 checks passed
@angela97lin angela97lin deleted the 833_drop_null branch Jun 8, 2020
@angela97lin angela97lin mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a preprocessing component to drop null columns
3 participants