-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds drop null columns preprocessing component #834
Conversation
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 188 191 +3
Lines 7338 7428 +90
=======================================
+ Hits 7314 7404 +90
Misses 24 24
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did a quick pass. should get one more approval before merging
evalml/pipelines/components/transformers/preprocessing/drop_null_columns.py
Outdated
Show resolved
Hide resolved
evalml/pipelines/components/transformers/preprocessing/drop_null_columns.py
Outdated
Show resolved
Hide resolved
evalml/pipelines/components/transformers/preprocessing/drop_null_columns.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests look great! I left a couple questions, one about making _cols_to_drop
private and another about the boundary condition. But this looks ready to merge! We can finish those discussions and update if necessary.
Closes #833