Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog check job: expect new branch prefixing from dep updates bot #836

Merged
merged 2 commits into from Jun 4, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Jun 4, 2020

We changed the branch strategy of the update deps bot to fix a weird github/circleci bug. We should also update the changelog checkin job to continue to mark update deps PRs as green.

@dsherry dsherry added enhancement An improvement to an existing feature. testing Issues related to testing. labels Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #836 into master will increase coverage by 9.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   90.35%   99.67%   +9.32%     
==========================================
  Files         188      188              
  Lines        7338     7338              
==========================================
+ Hits         6630     7314     +684     
+ Misses        708       24     -684     
Impacted Files Coverage Δ
evalml/tests/component_tests/test_components.py 100.00% <0.00%> (+0.55%) ⬆️
evalml/automl/auto_search_base.py 97.91% <0.00%> (+0.59%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.74% <0.00%> (+2.25%) ⬆️
evalml/tests/component_tests/test_utils.py 96.42% <0.00%> (+3.57%) ⬆️
evalml/pipelines/pipeline_base.py 100.00% <0.00%> (+6.00%) ⬆️
evalml/tests/utils_tests/test_dependencies.py 100.00% <0.00%> (+6.25%) ⬆️
...ts/automl_tests/test_auto_classification_search.py 100.00% <0.00%> (+14.28%) ⬆️
.../tests/automl_tests/test_auto_regression_search.py 100.00% <0.00%> (+17.60%) ⬆️
evalml/tests/pipeline_tests/test_graphs.py 100.00% <0.00%> (+26.02%) ⬆️
...nents/estimators/classifiers/xgboost_classifier.py 100.00% <0.00%> (+34.28%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21a2aa...d4c3a49. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

nice catch!

@dsherry dsherry force-pushed the ds_update_deps_changelog_job branch from 1446efb to 7b17405 Compare Jun 4, 2020
Copy link
Contributor

@angela97lin angela97lin left a comment

Nice, LGTM!

@dsherry dsherry force-pushed the ds_update_deps_changelog_job branch from 7b17405 to d4c3a49 Compare Jun 4, 2020
@dsherry dsherry merged commit d8a8b42 into master Jun 4, 2020
2 checks passed
@dsherry dsherry deleted the ds_update_deps_changelog_job branch Jun 4, 2020
@angela97lin angela97lin mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature. testing Issues related to testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants