Have all_components and all_pipelines try to initialize components/pipelines #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 195 195
Lines 7738 7740 +2
=======================================
+ Hits 7714 7716 +2
Misses 24 24
Continue to review full report at Codecov.
|
jeremyliweishih
approved these changes
Jun 12, 2020
| @@ -92,6 +92,6 @@ def handle_component(component): | |||
| raise ValueError("handle_component only takes in str or ComponentBase") | |||
| components = all_components() | |||
| if component not in components: | |||
| raise KeyError("Component {} was not found".format(component)) | |||
| raise MissingComponentError('Component "{}" was not found'.format(component)) | |||
| component = handle_component(component) | ||
| try: | ||
| component = handle_component(component) | ||
| except MissingComponentError as e: |
There was a problem hiding this comment.
Thanks yeah I like the way this fits together now!
…pelines and skip on ImportError or related errors
dsherry
force-pushed
the
ds_523_init_components_pipelines
branch
from
7745a61 to
25368c2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #523
Update
all_components()andall_pipelines()to try to initialize components and pipelines, and if there are failures related to import, skip them.This replaces the hacky import_or_raise stuff I had hard-coded for our optional modeling deps xgboost and catboost.