Fixed bug where PerColumnImputer cannot handle dropped columns #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 195 195
Lines 7930 7962 +32
=======================================
+ Hits 7906 7938 +32
Misses 24 24
Continue to review full report at Codecov.
|
angela97lin
commented
Jun 15, 2020
| @@ -50,7 +51,7 @@ def fit(self, X, y=None): | |||
| strategy_dict = self.impute_strategies.get(column, dict()) | |||
| strategy = strategy_dict.get('impute_strategy', self.default_impute_strategy) | |||
| fill_value = strategy_dict.get('fill_value', None) | |||
| self.imputers[column] = SkImputer(strategy=strategy, fill_value=fill_value) | |||
| self.imputers[column] = SimpleImputer(impute_strategy=strategy, fill_value=fill_value) | |||
There was a problem hiding this comment.
Rather than use SkImputer, I'm using our SimpleImputer which already handles the nan's from the previous PR :)
There was a problem hiding this comment.
🤯 oh, great idea!! Modularity always wins 👍😁
angela97lin
commented
Jun 15, 2020
| @@ -67,8 +68,14 @@ def transform(self, X, y=None): | |||
| pd.DataFrame: Transformed X | |||
| """ | |||
| X_t = X.copy() | |||
| cols_to_drop = [] | |||
There was a problem hiding this comment.
Can't set column to empty dataframe, so updating to check first.
dsherry
approved these changes
Jun 16, 2020
| @@ -50,7 +51,7 @@ def fit(self, X, y=None): | |||
| strategy_dict = self.impute_strategies.get(column, dict()) | |||
| strategy = strategy_dict.get('impute_strategy', self.default_impute_strategy) | |||
| fill_value = strategy_dict.get('fill_value', None) | |||
| self.imputers[column] = SkImputer(strategy=strategy, fill_value=fill_value) | |||
| self.imputers[column] = SimpleImputer(impute_strategy=strategy, fill_value=fill_value) | |||
There was a problem hiding this comment.
🤯 oh, great idea!! Modularity always wins 👍😁
evalml/pipelines/components/transformers/imputers/per_column_imputer.py
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #514 by addressing PerColumnImputer