Add kwargs to all components

[jeremyliweishih]

fixes #775.

[codecov]

Codecov Report

Merging #863 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   99.69%   99.70%           
=======================================
  Files         195      195           
  Lines        7962     8000   +38     
=======================================
+ Hits         7938     7976   +38     
  Misses         24       24           

Impacted Files	Coverage Δ
evalml/tests/pipeline_tests/test_pipelines.py	99.75% <ø> (-0.01%)	⬇️
evalml/pipelines/components/component_base.py	100.00% <100.00%> (ø)
...ents/estimators/classifiers/baseline_classifier.py	100.00% <100.00%> (ø)
...ents/estimators/classifiers/catboost_classifier.py	100.00% <100.00%> (ø)
...ts/estimators/classifiers/elasticnet_classifier.py	100.00% <100.00%> (ø)
...components/estimators/classifiers/et_classifier.py	100.00% <100.00%> (ø)
...ents/estimators/classifiers/logistic_regression.py	100.00% <100.00%> (ø)
...components/estimators/classifiers/rf_classifier.py	100.00% <100.00%> (ø)
...nents/estimators/classifiers/xgboost_classifier.py	100.00% <100.00%> (ø)
...onents/estimators/regressors/baseline_regressor.py	100.00% <100.00%> (ø)
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5de7d...89d89a2. Read the comment docs.

[jeremyliweishih]

@dsherry __module__ was the key!

[dsherry]

Amazing!!

[dsherry]

@jeremyliweishih is there a reason not to add **kwargs to ComponentBase.__init__? I think we should add that for consistency. I don't think we have transformer/estimator inits but same question there if so.

[jeremyliweishih]

@jeremyliweishih is there a reason not to add **kwargs to ComponentBase.__init__? I think we should add that for consistency. I don't think we have transformer/estimator inits but same question there if so.

@dsherry I can add it for consistency! It just wasn't actively doing anything in ComponentBase since the kwargs affects the component_objs. I wanted to add them to ComponentBase if there was a more general solution.

[dsherry]

@jeremyliweishih how come you specified new here? Why not let patch set up a MagicMock automatically?

with patch(patched) as mock_component_obj:
    component = component_class(test_arg="test")
    assert component.parameters['test_arg'] == "test"
    mock_component_obj.assert_called_with(test_arg="test")

[jeremyliweishih]

I don't have the exact error statement right now but MagicMock doesn't work directly with __init__ thus using the new=all_init. Before I had mocked_obj.__init__ = wtv and it didn't work.

[dsherry]

@jeremyliweishih got it, thanks. Yeah let's add **kwargs to ComponentBase.__init__/base class inits for consistency. Also I left a comment on the mocking in the unit test. Other than that LGTM!! Pretty cool that you figured out the dynamic mocking, great to have that pattern in place!

[jeremyliweishih]

@dsherry this replaces the check in test_pipelines.py on if components have random_state as a parameter.

[dsherry]

Awesome. Thanks