Fix Typos in Documentation #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #872 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 195 195
Lines 8365 8365
=======================================
Hits 8344 8344
Misses 21 21
Continue to review full report at Codecov.
|
jeremyliweishih
approved these changes
Jun 23, 2020
docs/source/changelog.rst
Outdated
| @@ -22,6 +22,7 @@ Changelog | |||
| * Enforce requirement that builtin components save all inputted values in their parameters dict :pr:`847` | |||
| * Don't list base classes in `all_components` output :pr:`847` | |||
| * Standardize all components to output pandas datastructures, and accept either pandas or numpy :pr:`853` | |||
| * Minor updates to documentation :pr:`872` | |||
There was a problem hiding this comment.
Could you add a bullet for * Documentation Changes like so in the past releases for this?
dsherry
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
@freddyaboulton thanks for this! All helpful. +1 to @jeremyliweishih comment about Documentation header in changelog but no changes requested other than that.
|
Thanks for the feedback @dsherry and @jeremyliweishih ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
A small first step towards completing #861.
Fixes minor typos in the documentation, adds periods to docstring summary lines, and updates the Evalml logo in the docs.
I added periods to summary lines to be consistent with the napoleon and PEP style guides.
I was not able to update the favicon.
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rstto include this pull request by adding :pr:123.