Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves permutation importance from evalml/pipeline/utils.py to graph_utils.py #880

Merged
merged 4 commits into from Jun 25, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Jun 24, 2020

Closes #875

@angela97lin angela97lin self-assigned this Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #880 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         195      195           
  Lines        8503     8505    +2     
=======================================
+ Hits         8482     8484    +2     
  Misses         21       21           
Impacted Files Coverage Δ
evalml/pipelines/__init__.py 100.00% <ø> (ø)
evalml/pipelines/graph_utils.py 100.00% <100.00%> (ø)
evalml/pipelines/utils.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_graphs.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.80% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69e1ed...5e0344d. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review Jun 24, 2020
@angela97lin angela97lin requested a review from dsherry Jun 24, 2020
@@ -39,6 +40,7 @@ Changelog
**Breaking Changes**
* Pipelines' static ``component_graph`` field must contain either ``ComponentBase`` subclasses or ``str``, instead of ``ComponentBase`` subclass instances :pr:`850`
* Rename ``handle_component`` to ``handle_component_class``. Now standardizes to ``ComponentBase`` subclasses instead of ``ComponentBase`` subclass instances :pr:`850`
* ``calculate_permutation_importances`` and ``graph_permutation_importances`` were moved from `evalml.pipeline.utils` to `evalml.pipeline.graph_utils` :pr:`880`
Copy link
Collaborator

@dsherry dsherry Jun 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we haven't released this yet, no need to add to breaking changes.

Also, perhaps you can just add the PR number to the end of the previous entry in "Enhancements" for #860

Copy link
Collaborator

@dsherry dsherry left a comment

Thank you!! Left one comment about the changelog but otherwise 🚢 !

@angela97lin angela97lin merged commit a27f6e1 into master Jun 25, 2020
2 checks passed
@angela97lin angela97lin deleted the 875_move branch Jun 25, 2020
@angela97lin angela97lin mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move permutation importance from evalml/pipeline/utils.py to graph_utils.py
2 participants