Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken properties when search has not been run #894

Merged
merged 11 commits into from
Jun 30, 2020
Merged

Fix broken properties when search has not been run #894

merged 11 commits into from
Jun 30, 2020

Conversation

jeremyliweishih
Copy link
Collaborator

Fixes #744.

@codecov
Copy link

codecov bot commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #894 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         195      195           
  Lines        9085     9132   +47     
=======================================
+ Hits         9066     9113   +47     
  Misses         19       19
Impacted Files Coverage Δ
evalml/automl/data_splitters/__init__.py 100.00% <ø> (ø)
evalml/automl/automl_search.py 98.78% <100.00%> (+0.03%) ⬆️
evalml/tests/automl_tests/test_automl.py 100.00% <100.00%> (ø)
.../automl_tests/test_automl_search_classification.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704fe03...02df829. Read the comment docs.

@jeremyliweishih jeremyliweishih marked this pull request as ready for review June 29, 2020 15:09
dsherry
dsherry approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I left a few suggestions. Nothing blocking except adding a docstring to has_searched. Once that's in will be 🚢 -able!

evalml/automl/automl_search.py Outdated Show resolved Hide resolved
evalml/automl/automl_search.py Show resolved Hide resolved
evalml/automl/automl_search.py Outdated Show resolved Hide resolved
evalml/automl/automl_search.py Outdated Show resolved Hide resolved
evalml/automl/automl_search.py Outdated Show resolved Hide resolved
evalml/tests/automl_tests/test_automl.py Outdated Show resolved Hide resolved
evalml/tests/automl_tests/test_automl.py Outdated Show resolved Hide resolved
evalml/tests/automl_tests/test_automl.py Outdated Show resolved Hide resolved
dsherry
dsherry reviewed Jun 30, 2020
View reviewed changes
evalml/automl/automl_search.py
@@ -669,12 +668,21 @@ def add_to_rankings(self, pipeline, X, y):
if not isinstance(y, pd.Series):
y = pd.Series(y)

if not self.has_searched:
raise RuntimeError("Please run automl search before calling `add_to_rankings()`")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dsherry
dsherry reviewed Jun 30, 2020
View reviewed changes
evalml/tests/automl_tests/test_automl.py
mock_score.return_value = {'Log Loss Binary': 0.1234}
test_pipeline = dummy_binary_pipeline_class(parameters={})
with pytest.raises(RuntimeError, match="Please run automl"):
automl.add_to_rankings(test_pipeline, X, y)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dsherry
dsherry approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremyliweishih LGTM!

@jeremyliweishih jeremyliweishih merged commit 2ebe223 into master Jun 30, 2020
@angela97lin angela97lin mentioned this pull request Jun 30, 2020
Merged
@dsherry dsherry deleted the js_744_before branch October 29, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddyaboulton freddyaboulton freddyaboulton left review comments

@dsherry dsherry dsherry approved these changes

@eccabay eccabay Awaiting requested review from eccabay

Assignees

@jeremyliweishih jeremyliweishih

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError for automl.rankings when no search is ran
3 participants
@jeremyliweishih @dsherry @freddyaboulton