Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code in _get_preprocessing_components #896

Merged
merged 15 commits into from Jul 1, 2020
Merged

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Jun 29, 2020

Closes #885

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #896 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         195      195           
  Lines        9132     9142   +10     
=======================================
+ Hits         9113     9123   +10     
  Misses         19       19           
Impacted Files Coverage Δ
evalml/pipelines/utils.py 100.00% <ø> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.82% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30a457...83e7086. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review Jun 29, 2020
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

@angela97lin This looks good to me 🚀

evalml/tests/pipeline_tests/test_pipelines.py Outdated Show resolved Hide resolved
@angela97lin angela97lin modified the milestones: June 2020, July 2020 Jun 30, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

Looks good!

@angela97lin angela97lin merged commit 3f20a06 into master Jul 1, 2020
2 checks passed
@angela97lin angela97lin deleted the 885_dead_code branch Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dead code in _get_preprocessing_components
3 participants