Skip to content

Remove dead code in _get_preprocessing_components #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 1, 2020
Merged

Remove dead code in _get_preprocessing_components #896

merged 15 commits into from
Jul 1, 2020

Conversation

angela97lin
Copy link
Contributor

Closes #885

@codecov
Copy link

codecov bot commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #896 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         195      195           
  Lines        9132     9142   +10     
=======================================
+ Hits         9113     9123   +10     
  Misses         19       19
Impacted Files Coverage Δ
evalml/pipelines/utils.py 100.00% <ø> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.82% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30a457...83e7086. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review June 29, 2020 21:41
@angela97lin angela97lin added this to the June 2020 milestone Jun 29, 2020
freddyaboulton
freddyaboulton approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin This looks good to me 🚀

@angela97lin angela97lin modified the milestones: June 2020, July 2020 Jun 30, 2020
dsherry
dsherry approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@angela97lin angela97lin merged commit 3f20a06 into master Jul 1, 2020
@angela97lin angela97lin deleted the 885_dead_code branch July 1, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@jeremyliweishih jeremyliweishih Awaiting requested review from jeremyliweishih

@eccabay eccabay Awaiting requested review from eccabay

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

Remove dead code in _get_preprocessing_components
3 participants
@angela97lin @dsherry @freddyaboulton