One-hot encoder: fix bug with column names, so all data types are supported #897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #882
The bug was that sklearn's one-hot encoder's
get_feature_names
method requires the input to bestr
, but in the case when the input dataframe has a non-string index, we were trying to pass that index in, causing an error.The fix is to first convert all the column names to
str
, then pass them intoget_feature_names
.