Skip to content

Move list_model_families to evalml.model_family.utils #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jul 1, 2020
Merged

Move list_model_families to evalml.model_family.utils #903

merged 28 commits into from
Jul 1, 2020

Conversation

angela97lin
Copy link
Contributor

Closes #864

@angela97lin angela97lin self-assigned this Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020 •
edited
Loading

Codecov Report

Merging #903 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #903   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         197      197           
  Lines        9204     9205    +1     
=======================================
+ Hits         9185     9186    +1     
  Misses         19       19
Impacted Files Coverage Δ
evalml/__init__.py 100.00% <ø> (ø)
evalml/model_family/__init__.py 100.00% <100.00%> (ø)
evalml/model_family/utils.py 100.00% <100.00%> (ø)
evalml/pipelines/utils.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a0bcc...04cbd28. Read the comment docs.

@angela97lin angela97lin added this to the July 2020 milestone Jul 1, 2020
@angela97lin angela97lin marked this pull request as ready for review July 1, 2020 17:20
@angela97lin angela97lin requested review from dsherry and removed request for dsherry July 1, 2020 17:53
dsherry
dsherry approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! 🚢

docs/source/changelog.rst
.. warning::

**Breaking Changes**
* ``list_model_families`` has been moved to ``evalml.model_family.utils`` (previously was under ``evalml.pipelines.utils``) :pr:`903`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@angela97lin angela97lin merged commit 99ee2e5 into master Jul 1, 2020
@angela97lin angela97lin deleted the 864_move_model_families branch July 1, 2020 20:52
@dsherry dsherry mentioned this pull request Jul 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

Move list_model_families to evalml.model_family.utils
2 participants
@angela97lin @dsherry