-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling KeyboardInterrupt in AutoMLSearch #915
Conversation
Codecov Report
@@ Coverage Diff @@
## main #915 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 170 170
Lines 8593 8645 +52
=======================================
+ Hits 8581 8633 +52
Misses 12 12
Continue to review full report at Codecov.
|
8f210d3
to
bbae31f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good - I agree with the implementation. Still taking a closer look but one thing is to add to the docs with a tutorial or explanation of how this feature works (maybe under "AUTOMATED MACHINE LEARNING").
…ests to use callbacks.
…e KeyboardInterrupt exceptions in search.
e969c7b
to
c0b01d1
Compare
@jeremyliweishih I added a section to the AutoML tutorial on how to stop the search. Let me know if you want me to make any edits! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@freddyaboulton LGTM. What do you think about adding your GIF onto the docs as well? I think it would look good but not blocking!
@jeremyliweishih Good idea! |
Pull Request Description
Fixes #250 by catching KeyboardInterrupt exceptions in AutoML search. I think the functionality matches what's described in the original ticket (see demo below) but I wanted to call out the following limitation:
fit
is implemented in sklearn/catboost/xgboost libraries.Demo
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rst
to include this pull request by adding :pr:123
.