Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master to main #918

Merged
merged 6 commits into from Jul 8, 2020
Merged

Update master to main #918

merged 6 commits into from Jul 8, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Jul 8, 2020

Fix #912

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #918 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         168      168           
  Lines        8331     8331           
=======================================
  Hits         8317     8317           
  Misses         14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f6c79...0c63b80. Read the comment docs.

@dsherry dsherry changed the base branch from master to main Jul 8, 2020
@dsherry dsherry changed the base branch from main to master Jul 8, 2020
@dsherry dsherry marked this pull request as ready for review Jul 8, 2020
@dsherry dsherry changed the base branch from master to main Jul 8, 2020
@dsherry
Copy link
Collaborator Author

dsherry commented Jul 8, 2020

Note this will merge to main, not master. Once this is approved, my plan is to update the repo default to main and merge.

contributing.md Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
contributing.md Outdated Show resolved Hide resolved
@dsherry dsherry requested a review from rwedge Jul 8, 2020
.github/codecov.yml Outdated Show resolved Hide resolved
docs/source/conf.py Show resolved Hide resolved
@dsherry dsherry requested a review from rwedge Jul 8, 2020
rwedge
rwedge approved these changes Jul 8, 2020
Copy link
Contributor

@rwedge rwedge left a comment

Looks good

Copy link
Contributor

@angela97lin angela97lin left a comment

Nice, looks like you've already changed the default on RtD too? :D

@dsherry dsherry merged commit ea8294e into main Jul 8, 2020
2 checks passed
@dsherry dsherry deleted the ds_912_main branch Jul 8, 2020
@dsherry dsherry mentioned this pull request Jul 8, 2020
@dsherry dsherry mentioned this pull request Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename master to main
3 participants