Update Results Getter #919
Conversation
Codecov Report
@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 168 168
Lines 8331 8348 +17
=======================================
+ Hits 8317 8334 +17
Misses 14 14
Continue to review full report at Codecov.
|
| mock_score.return_value = {'Log Loss Binary': 1.0} | ||
| automl.search(X, y) | ||
|
|
||
| assert automl.results['pipeline_results'][0]['score'] == 1.0 |
There was a problem hiding this comment.
Nice. Any reason you can't do something like assert automl.results == {'pipeline_results': {[{'score': 1.0, ...}]}, 'search_order': [0]} ?
There was a problem hiding this comment.
Yes. One, it's really long (900 characters). Two, I think that if anyone changes any small part of how results are delivered, they would necessarily have to update the test (if they change this specific part of the dictionary they would also have to update the test, but that seems like it would happen with less frequency). I am happy to add more assertions maybe checking the keys of some dictionaries, but I think checking the whole dict matching isn't necessarily worth it. Let me know what you think.
There was a problem hiding this comment.
That's convincing! Sounds good. I forgot how much stuff ends up in here.
| automl.results = 2.0 | ||
|
|
||
| automl.results['pipeline_results'][0]['score'] = 2.0 | ||
| assert automl.results['pipeline_results'][0]['score'] == 1.0 |
Fixes #274. Makes sure that results are read-only with @ property decorator.