Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nlp_primitives installation and remove extra requirement #924

Merged
merged 3 commits into from
Jul 11, 2020

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Jul 10, 2020

Fix #925

Two issues:

  1. The nlp_primitives library is in the core-requirements.txt file twice -- once as featuretools[nlp_primitives], once as nlp-primitives
  2. Tensorflow needs an older version of scipy than pip is installing:

Screen Shot 2020-07-10 at 6 55 12 PM

This error doesn't appear to be impacting things but can be fixed by adding an upper bound for the scipy package, until tensorflow removes their upper bound.

It might also be a good idea to set minimum requirements for the featuretools / nlp primitives libraries but that may be out of scope

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #924 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         170      170           
  Lines        8578     8578           
=======================================
  Hits         8564     8564           
  Misses         14       14           
Impacted Files Coverage Δ
evalml/tests/utils_tests/test_cli_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923eb25...f63ab0a. Read the comment docs.

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rwedge ! Makes sense to me

@dsherry
Copy link
Contributor

dsherry commented Jul 11, 2020

I tried this out locally and it fixed the issue for me. And I didn't see the error/warning I mentioned in #925

@rwedge rwedge merged commit d002520 into main Jul 11, 2020
@dsherry dsherry mentioned this pull request Jul 16, 2020
@dsherry dsherry deleted the rw_single_nlp_import branch October 29, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in pip install and warning on import after adding text/featuretools
2 participants