Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have automl search raise config errors in init instead of search #933

Merged
merged 11 commits into from Jul 16, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Jul 15, 2020

Continuation of #930, closes #865

@angela97lin angela97lin self-assigned this Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #933 into main will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
+ Coverage   99.83%   99.85%   +0.02%     
==========================================
  Files         170      170              
  Lines        8578     8565      -13     
==========================================
- Hits         8564     8553      -11     
+ Misses         14       12       -2     
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.26% <100.00%> (+0.47%) ⬆️
evalml/tests/automl_tests/test_automl.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d002520...e31b30a. Read the comment docs.

def test_objective_at_search_time(X_y_multi):
X, y = X_y_multi
error_automl = AutoMLSearch(problem_type='multiclass', additional_objectives=['Precision', 'AUC'],)
def test_incompatible_additional_objectives():
with pytest.raises(ValueError, match="is not compatible with a "):
error_automl.search(X, y)
Copy link
Contributor Author

@angela97lin angela97lin Jul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked this test a little via rename and updating to check during initialization.

@angela97lin angela97lin marked this pull request as ready for review Jul 15, 2020
@angela97lin angela97lin requested review from ctduffy and dsherry Jul 15, 2020
@angela97lin angela97lin added this to the July 2020 milestone Jul 15, 2020
Copy link
Contributor

@ctduffy ctduffy left a comment

looks good to me!

Copy link
Collaborator

@dsherry dsherry left a comment

LGTM!

evalml/automl/automl_search.py Show resolved Hide resolved
@angela97lin angela97lin merged commit c2bad29 into main Jul 16, 2020
2 checks passed
@angela97lin angela97lin deleted the 865_init_error branch Jul 16, 2020
@dsherry dsherry mentioned this pull request Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have automl search raise config errors in init instead of search
3 participants