Have automl search raise config errors in init instead of search #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #933 +/- ##
==========================================
+ Coverage 99.83% 99.85% +0.02%
==========================================
Files 170 170
Lines 8578 8565 -13
==========================================
- Hits 8564 8553 -11
+ Misses 14 12 -2
Continue to review full report at Codecov.
|
angela97lin
commented
Jul 15, 2020
angela97lin
commented
Jul 15, 2020
angela97lin
commented
Jul 15, 2020
Comment on lines
-621
to
-625
| def test_objective_at_search_time(X_y_multi): | ||
| X, y = X_y_multi | ||
| error_automl = AutoMLSearch(problem_type='multiclass', additional_objectives=['Precision', 'AUC'],) | ||
| def test_incompatible_additional_objectives(): | ||
| with pytest.raises(ValueError, match="is not compatible with a "): | ||
| error_automl.search(X, y) |
There was a problem hiding this comment.
Reworked this test a little via rename and updating to check during initialization.
ctduffy
reviewed
Jul 15, 2020
ctduffy
reviewed
Jul 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #930, closes #865