Move predict_proba and predict tests regarding string / categorical targets to test_pipelines.py
#972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #972 +/- ##
==========================================
+ Coverage 99.67% 99.87% +0.20%
==========================================
Files 174 174
Lines 8990 9043 +53
==========================================
+ Hits 8961 9032 +71
+ Misses 29 11 -18
Continue to review full report at Codecov.
|
freddyaboulton
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
@angela97lin This looks good to me! Just had a couple of non-blocking questions.
dsherry
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
@angela97lin nice! I ran this locally and it took 23sec total. Not bad given that we're trying each combo of estimator and target type for both binary and multiclass! Sounds good to me 😁
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates test added in #951 by moving
predict_probaandpredicttests regarding string / categorical targets totest_pipelines.py.Also adds some new pyfixtures which should be useful for creating pipelines for every available estimator in evalml. I wanted to use this to ensure that no particular estimator had some weird output that would break the code, and think it would be useful for scenarios where we want to do more comprehensive testing with pipelines.